code readibility refactor

index.js

@@ -6,6 +6,9 @@ const port = 3000
 const app = express()
 require('dotenv').config()
 
+//TODO change password option will be cool
+//TODO delete user option will be also cool
+
 app.use(express.json());
 app.use(express.urlencoded({ extended: true }));
 app.use(express.static(path.join(__dirname, 'public')));
@@ -21,25 +24,28 @@ app.post('/auth/login', async function(req, res) {
     let username = req.body.username.trim();
     let password = req.body.password.trim();
 
-    if (username && password) {
-        try {
-            const result = await client.query('SELECT * FROM accounts WHERE username = $1 AND password = $2', [username, password]);
-            if (result.rows.length > 0) {
-                // Authenticate the user
-                req.session.loggedin = true;
-                req.session.username = username;
-                res.redirect('/');
-            } else {
-                res.send('Incorrect Username or Password!');
+    async function loginUser (username, password) {
+        if (username && password) {
+            try {
+                const result = await client.query('SELECT * FROM accounts WHERE username = $1 AND password = $2', [username, password]);
+                if (result.rows.length > 0) {
+                    // Authenticate the user
+                    req.session.loggedin = true;
+                    req.session.username = username;
+                    res.redirect('/');
+                } else {
+                    res.send('Incorrect Username or Password!');
+                }
+            } catch (error) {
+                console.error('Error executing query', error);
+                res.status(500).send('Error executing query');
             }
-        } catch (error) {
-            console.error('Error executing query', error);
-            res.status(500).send('Error executing query');
+        } else {
+            res.send('Please enter Username and Password!');
         }
-    } else {
-        res.send('Please enter Username and Password!');
+        res.end();
+
     }
-    res.end();
 });
 
 app.post('/auth/signup', (req, res) => {
@@ -58,16 +64,13 @@ app.post('/auth/signup', (req, res) => {
         const values = [username, password];
 
         try {
-            const res = await client.query(query, values);
-            console.log('Account created:', res.rows[0]);
-            res.status(200).send('Account successfully created');
+            const signupData = await client.query(query, values);
+            console.log('Account created:', signupData.rows[0]);
+            res.status(200).send("Account successfully created <a href=/login>Login screen</a>");
         } catch (err) {
             console.error('Error inserting data:', err.stack);
+            res.status(500).send('Error inserting data');
         }
-        // client.end()
-        //     .then(() => console.log('Connection closed'))
-        //     .catch(err => console.log(err));
-
     }
 })
 app.get('/login', (req, res) => {

public/js/login.js

@@ -1,6 +1,5 @@
 function showPasswd() {
     let x = document.getElementById("password");
-    let y = document.getElementById("sPassword");
     if(x.type == "password"){
         x.type = "text";
         y.type = "text";